Skip to content

Add error codes for live object rest apis#293

Merged
zknill merged 1 commit intomainfrom
zak/pub-1191/fetch-endpoint
Mar 31, 2025
Merged

Add error codes for live object rest apis#293
zknill merged 1 commit intomainfrom
zak/pub-1191/fetch-endpoint

Conversation

@zknill
Copy link
Copy Markdown
Contributor

@zknill zknill commented Mar 12, 2025

These two error codes are used for fetching live object state from the rest api.
They indicate two cases where the API is unable to provide a response because of the state of the object.

Comment thread protocol/errors.json Outdated
"92000": "invalid object message",
"92001": "objects limit exceeded",
"92002": "unable to submit operation on tombstone object",
"92003": "unable to fetch state tree with tombstone object as root",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"92003": "unable to fetch state tree with tombstone object as root",
"92003": "unable to fetch objects tree with tombstone object as root",

Comment thread protocol/errors.json Outdated
"92001": "objects limit exceeded",
"92002": "unable to submit operation on tombstone object",
"92003": "unable to fetch state tree with tombstone object as root",
"92004": "unable to fetch state tree for not found object as root",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"92004": "unable to fetch state tree for not found object as root",
"92004": "object not found",

per suggestion in https://github.com/ably/realtime/pull/7212#discussion_r1993943642

@zknill zknill force-pushed the zak/pub-1191/fetch-endpoint branch from fabead9 to 9fe839d Compare March 14, 2025 14:05
@zknill zknill force-pushed the zak/pub-1191/fetch-endpoint branch 2 times, most recently from f1aaa0a to 5507e80 Compare March 28, 2025 15:01
@zknill zknill requested a review from mschristensen March 28, 2025 15:01
@zknill zknill enabled auto-merge March 31, 2025 08:27
@zknill zknill force-pushed the zak/pub-1191/fetch-endpoint branch from 5507e80 to 1d6c839 Compare March 31, 2025 08:28
@zknill zknill merged commit 9e05f2e into main Mar 31, 2025
2 checks passed
@zknill zknill deleted the zak/pub-1191/fetch-endpoint branch March 31, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants